Address PR #182 review feedback: refactor batch handling and fix test issues

[Copilot]

Addresses review feedback from PR #182 which introduced conditional thread pool usage for small rule batches.

Changes

Extract duplicate batch result handling logic

The single-batch and multi-batch paths duplicated counter updates and progress bar rendering. Extracted into _handle_batch_result():

def _handle_batch_result(result: Optional[List[str]]):
    nonlocal successful_batches
    if result:
        successful_batches += 1
        existing_rules.update(result)
    render_progress_bar(successful_batches, total_batches, f"Folder {sanitize_for_log(folder_name)}")

# Now both paths use the helper
if total_batches == 1:
    result = process_batch(1, batches[0])
    _handle_batch_result(result)
else:
    with concurrent.futures.ThreadPoolExecutor(max_workers=3) as executor:
        # ...
        _handle_batch_result(result)

Fix import-time side effects in test_push_rules_perf.py

Moved import main from module level into test methods to prevent import-time execution of load_dotenv() and USE_COLORS computation. Matches pattern in test_plan_details.py.

Fix mock future reuse in test_multi_batch_uses_thread_pool

Test was returning identical mock future for each submit() call, causing all batches to collapse into single dict entry. Now uses distinct futures:

mock_future1, mock_future2 = MagicMock(), MagicMock()
mock_executor_instance.submit.side_effect = [mock_future1, mock_future2]
mock_as_completed.return_value = [mock_future1, mock_future2]

Documentation and linting

• Added module/class docstrings to test_push_rules_perf.py
• Fixed markdown reference syntax in .jules/bolt.md
• All ruff checks pass

Original prompt

Hi @copilot, please open a new pull request to apply changes based on the comments in this thread for Pull Request: #182. Thank you!

Custom agent used: Development Partner
The Development Partner Protocol

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[trunk-io]

Merging to main in this repository is managed by Trunk.

• To merge this pull request, check the box to the left or comment /trunk merge below.

[github-actions]

👋 Development Partner is reviewing this PR. Will provide feedback shortly.