Conversation
|
Merging to
|
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
👋 Development Partner is reviewing this PR. Will provide feedback shortly. |
There was a problem hiding this comment.
Pull request overview
Adds a new agentic /plan command workflow intended to generate project plans by creating up to 5 grouped sub-issues via Safe Outputs.
Changes:
- Introduces
.github/workflows/plan.mdas the gh-aw workflow source/prompt for the planning assistant. - Adds the generated
.github/workflows/plan.lock.ymlGitHub Actions workflow compiled from the source.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/plan.md | Defines the /plan workflow frontmatter plus the agent prompt/instructions for generating sub-issues. |
| .github/workflows/plan.lock.yml | Auto-generated compiled workflow that runs the Copilot agent and processes Safe Outputs (issue creation / discussion close). |
| description: Generates project plans and task breakdowns when invoked with /plan command in issues or PRs | ||
| on: | ||
| slash_command: | ||
| name: plan | ||
| events: [issue_comment, discussion_comment] |
There was a problem hiding this comment.
The workflow description says it can be invoked in “issues or PRs”, but this workflow is only configured for issue_comment/discussion_comment and the generated activation logic excludes PR issue comments (github.event.issue.pull_request == null). Please either update the description to match actual behavior, or update triggers/conditions to support PRs as advertised.
| Each task should: | ||
| - Be completable in a single PR | ||
| - Not be too large (avoid epic-sized tasks) | ||
| - With a single focus or goal. Keep them extremely small and focused even it means more tasks. |
There was a problem hiding this comment.
Grammar: “Keep them extremely small and focused even it means more tasks.” should be “even if it means more tasks.”
| - With a single focus or goal. Keep them extremely small and focused even it means more tasks. | |
| - With a single focus or goal. Keep them extremely small and focused even if it means more tasks. |
|
|
||
| ## Instructions | ||
|
|
||
| Review instructions in `.github/instructions/*.instructions.md` if you need guidance. |
There was a problem hiding this comment.
.github/instructions/*.instructions.md is referenced here, but there is no .github/instructions/ directory in the repo. This will send the agent looking for guidance that doesn’t exist; point to the actual instructions file/location (e.g., .github/copilot-instructions.md) or remove the reference.
| Review instructions in `.github/instructions/*.instructions.md` if you need guidance. | |
| Review any repository-specific instructions (for example, CONTRIBUTING.md, README, or docs/) if you need guidance. |
| permissions: {} | ||
|
|
||
| concurrency: | ||
| group: "gh-aw-${{ github.workflow }}-${{ github.event.issue.number || github.event.pull_request.number }}" |
There was a problem hiding this comment.
Concurrency group uses only github.event.issue.number || github.event.pull_request.number. For discussion_comment triggers both are unset, so the group becomes the same for all discussions and runs can cancel each other unexpectedly. Include github.event.discussion.number (or another unique discussion identifier) in the group expression if discussion triggers are intended to be supported.
| group: "gh-aw-${{ github.workflow }}-${{ github.event.issue.number || github.event.pull_request.number }}" | |
| group: "gh-aw-${{ github.workflow }}-${{ github.event.issue.number || github.event.pull_request.number || github.event.discussion.number || github.run_id }}" |
Add agentic workflow plan