🎨 Palette: Improve feedback for long waits in CI/non-interactive mode by abhimehro · Pull Request #265 · abhimehro/ctrld-sync

abhimehro · 2026-02-15T22:56:32Z

💡 What: Updated countdown_timer to log periodic status updates (every 10s) instead of sleeping silently in non-color environments.
🎯 Why: In CI or non-interactive terminals, long waits (e.g., 60s for deletion propagation) appeared as hung processes, causing user anxiety.
📸 Before/After: Before: Silent sleep. After: "Waiting: 50s remaining...", "Waiting: 40s remaining..."
♿ Accessibility: Improves experience for users relying on logs or screen readers in non-interactive mode.
Reference: Updated tests/test_ux.py and fixed tests/test_push_rules_perf.py to handle dynamic imports.

PR created automatically by Jules for task 17019950799559030425 started by @abhimehro

- Update `countdown_timer` in `main.py` to log periodic updates every 10s in non-color mode. - Update `tests/test_ux.py` to verify the new behavior. - Fix test pollution in `tests/test_push_rules_perf.py` by using dynamic imports. - Create `.Jules/palette.md` to document the learning. Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>

google-labs-jules · 2026-02-15T22:56:33Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

trunk-io · 2026-02-15T22:56:35Z

😎 Merged manually by @abhimehro - details.

github-actions · 2026-02-15T22:56:41Z

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

gemini-code-assist · 2026-02-15T22:56:47Z

Summary of Changes

Hello @abhimehro, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience in non-interactive environments, particularly CI, by addressing the issue of silent, long-duration waits. Previously, operations like waiting for deletion propagation could appear as frozen processes, causing user uncertainty. The core change introduces periodic status updates in the countdown_timer function, ensuring users receive clear feedback on remaining wait times. This improvement is complemented by updated test coverage and a refinement in how modules are imported within certain test files to maintain test stability.

Highlights

Enhanced User Feedback for Long Waits: The countdown_timer function now provides periodic log updates (every 10 seconds) in non-interactive environments (e.g., CI) for waits exceeding 10 seconds, preventing the appearance of hung processes and reducing user anxiety.
Improved Test Coverage for Countdown Timer: The test suite for countdown_timer was updated to include specific test cases for both short and long waits in non-color mode, ensuring the new periodic logging behavior is correctly verified.
Refactored Module Import in Tests: The main module import in tests/test_push_rules_perf.py was refactored to dynamically handle reloads, improving test reliability and preventing potential import conflicts.
Documented Best Practice: A new learning note was added to .Jules/palette.md emphasizing the importance of providing feedback during long silent waits in CLI tools, especially in non-interactive environments.

Changelog

.Jules/palette.md
- Added a new entry documenting the learning and action regarding silent waits in CI.
main.py
- Modified countdown_timer to provide periodic status updates (every 10s) instead of silent sleeping when USE_COLORS is false and the wait is longer than 10 seconds.
- Implemented a loop to log remaining time and sleep in steps for long waits.
tests/test_push_rules_perf.py
- Changed import main to dynamically import main using importlib in setUp to prevent issues with module reloads.
- Updated calls to main.push_rules to use self.main.push_rules after dynamic import.
tests/test_ux.py
- Renamed test_countdown_timer_no_colors to test_countdown_timer_no_colors_short and updated its assertion to check for no log calls for short waits.
- Added test_countdown_timer_no_colors_long to verify periodic log updates and correct sleep calls for long waits in non-color mode.

Activity

The pull request was automatically created by Jules for a task started by @abhimehro.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

tests/test_ux.py

+    # 1. "LongWait: 15s remaining..." (after first sleep/loop iteration)
+    # 2. "LongWait: 5s remaining..." (after second sleep/loop iteration)
+
+    assert mock_sleep.call_count == 3


tests/test_ux.py

+    mock_sleep.assert_any_call(10)
+    mock_sleep.assert_any_call(5)
+
+    assert mock_log.info.call_count == 2


Copilot

Pull request overview

Improves CLI UX in CI/non-interactive environments by adding periodic “heartbeat” log updates during long waits, rather than appearing to hang silently.

Changes:

Update countdown_timer to emit periodic log.info updates in no-color mode for waits >10s.
Expand UX tests to cover both short (silent) and long (periodic log) no-color countdown behavior.
Adjust a perf test to reference main via sys.modules and add a Jules “palette” note documenting the UX lesson.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`main.py`	Adds periodic logging for long waits when `USE_COLORS` is false.
`tests/test_ux.py`	Splits/extends countdown timer tests to validate short vs long no-color behavior.
`tests/test_push_rules_perf.py`	Switches to using `self.main` derived from `sys.modules` to be resilient to module reloads.
`.Jules/palette.md`	Adds a short “palette” note about avoiding silent waits in CI.

main.py

tests/test_ux.py

tests/test_push_rules_perf.py

Copilot · 2026-02-15T22:59:55Z

.Jules/palette.md

+## 2025-01-26 - [Silent Waits in CI]
+**Learning:** Long silent waits in CLI tools (especially in CI/non-interactive mode) cause user anxiety about hung processes.
+**Action:** Always provide periodic heartbeat logs (e.g. every 10s) for long operations in non-interactive environments.


This introduces a new .Jules/ directory, but the repo already has a .jules/ directory. Having both differs only by case and can cause checkout/merge issues on case-insensitive filesystems (Windows/macOS). Consider placing this file under the existing .jules/ directory (or standardizing on one casing).

gemini-code-assist

Code Review

This pull request introduces a valuable user experience improvement for non-interactive environments by adding periodic status updates during long waits, preventing the appearance of a hung process. However, a medium-severity log injection vulnerability was identified in a new logging statement within the countdown_timer function, as it fails to sanitize the message parameter. It is recommended to apply the existing sanitize_for_log function to mitigate this risk. Additionally, a minor refinement is suggested for test_push_rules_perf.py to improve test robustness against pollution.

main.py

tests/test_push_rules_perf.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-02-16T02:13:42Z

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

github-actions · 2026-02-16T02:13:50Z

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-02-16T02:14:13Z

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

github-actions · 2026-02-16T02:14:28Z

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

github-actions · 2026-02-16T02:14:36Z

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

…99559030425

github-actions · 2026-02-16T02:47:03Z

👋 Development Partner is reviewing this PR. Will provide feedback shortly.

Copilot AI review requested due to automatic review settings February 15, 2026 22:56

github-actions bot added the python label Feb 15, 2026

github-advanced-security bot found potential problems Feb 15, 2026

View reviewed changes

Copilot started reviewing on behalf of abhimehro February 15, 2026 22:57 View session

Copilot AI reviewed Feb 15, 2026

View reviewed changes

gemini-code-assist bot reviewed Feb 15, 2026

View reviewed changes

main.py Outdated Show resolved Hide resolved

tests/test_push_rules_perf.py Outdated Show resolved Hide resolved

abhimehro and others added 2 commits February 15, 2026 20:13

Update main.py

251c359

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/test_ux.py

1373062

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/test_push_rules_perf.py

304d582

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

abhimehro and others added 2 commits February 15, 2026 20:14

Update main.py

41c43e1

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update tests/test_push_rules_perf.py

78f07d3

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

abhimehro assigned abhimehro, Copilot, Claude and Codex Feb 16, 2026

Merge branch 'main' into palette-ux-improvement-ci-feedback-170199507…

c373a3f

…99559030425

abhimehro merged commit 6c0f025 into main Feb 16, 2026
9 of 11 checks passed

abhimehro deleted the palette-ux-improvement-ci-feedback-17019950799559030425 branch February 16, 2026 02:47

github-actions bot mentioned this pull request Feb 16, 2026

[repo-status] 🌟 Daily Repo Status - February 16, 2026 #287

Closed

Copilot AI mentioned this pull request Feb 17, 2026

Fix README clone URL placeholder #296

Closed

This was referenced Feb 17, 2026

[repo-status] Daily Status Report - February 17, 2026 🌟 #316

Closed

[repo-status] Daily Repo Status - February 18, 2026 🌟 #351

Closed

Conversation

abhimehro commented Feb 15, 2026

Uh oh!

google-labs-jules bot commented Feb 15, 2026

Uh oh!

trunk-io bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 15, 2026

Uh oh!

gemini-code-assist bot commented Feb 15, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

Check notice

Check notice

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

trunk-io bot commented Feb 15, 2026 •

edited

Loading