🎨 Palette: Enhance CLI progress bars and summary table#360
Conversation
…summary table - Updated progress bar empty character from '░' to '·' for a cleaner look. - Implemented `print_summary_table` to render a polished Unicode box-drawing table when colors are enabled, falling back to ASCII otherwise. - Extracted table rendering logic into a reusable function for better organization. - Updated `tests/test_ux.py` to assert the new progress bar character. Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
😎 Merged manually by @abhimehro - details. |
|
👋 Development Partner is reviewing this PR. Will provide feedback shortly. |
Summary of ChangesHello @abhimehro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the command-line interface's user experience by refining its visual elements. The changes focus on making progress indicators less obtrusive and presenting summary information in a more structured and aesthetically pleasing format, ultimately contributing to a more professional and user-friendly CLI output. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR enhances the CLI user experience with visual polish improvements to progress bars and the summary table. It replaces the noisy ░ character with the cleaner · (middle dot) in progress bars, and refactors the summary table printing into a dedicated function that uses Unicode box-drawing characters for a more polished report appearance.
Changes:
- Replaced
░with·(middle dot) in progress bars for a cleaner visual appearance - Extracted summary table printing logic into a new
print_summary_tablefunction with Unicode box-drawing support - Increased Rules column width from 10 to 12 characters to better accommodate large numbers with thousand separators
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| main.py | Updated progress bar characters in countdown_timer and render_progress_bar; added new print_summary_table function with Unicode box-drawing support; refactored main() to use the new function |
| tests/test_ux.py | Updated test assertion to verify the new middle dot character instead of the old light shade character |
There was a problem hiding this comment.
Code Review
This pull request is a great step forward in improving the CLI's visual presentation. The new progress bars are cleaner, and the summary table is much more professional. The refactoring of the table printing logic into its own function is also a good move for code clarity. I've found a minor alignment issue in the new Unicode summary table that could cause a visual glitch. My feedback includes a suggested fix for this.
|
👋 Development Partner is reviewing this PR. Will provide feedback shortly. |
- Updated progress bar empty character from '░' to '·' for a cleaner look. - Implemented `print_summary_table` to render a polished Unicode box-drawing table when colors are enabled, falling back to ASCII otherwise. - Extracted table rendering logic into a reusable function. - Updated `tests/test_ux.py` to assert the new progress bar character. - Fixed `TypeError` in `tests/test_content_type.py` caused by duplicate method definition in merged code. Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
|
👋 Development Partner is reviewing this PR. Will provide feedback shortly. |
|
👋 Development Partner is reviewing this PR. Will provide feedback shortly. |
This PR enhances the CLI user experience by improving visual polish:
░character with·(middle dot) for the empty portion of progress bars.print_summary_tablefunction that uses Unicode box-drawing characters when supported (USE_COLORS=True). This makes the final summary report look like a proper "card" or report.main().Tested manually with
python main.py --dry-runand verified automated tests pass.PR created automatically by Jules for task 10990759234046850177 started by @abhimehro