Skip to content

Add test.yml workflow for automatic PR test validation #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Add test.yml workflow for automatic PR test validation #402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28ad353
Initial plan
Copilot Feb 20, 2026
6ee4313
feat: add test.yml workflow for PR validation (#338)
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Tests

on:
pull_request:
branches: [main, develop]
push:
branches: [main, develop]
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding workflow_dispatch: trigger to allow manual test runs. This is a common pattern throughout the repository (used in sync.yml, performance.yml, and all agentic workflows) and would allow developers to manually trigger test runs without creating a commit. This is particularly useful when testing CI configuration changes or investigating test failures.

Suggested change
branches: [main, develop]
branches: [main, develop]
workflow_dispatch:

Copilot uses AI. Check for mistakes.

jobs:
test:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v4

- name: Set up Python 3.13
uses: actions/setup-python@v5
with:
python-version: '3.13'

- name: Set up uv
uses: astral-sh/setup-uv@v4

Comment on lines +17 to +24
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup order differs from the existing performance.yml workflow pattern. In performance.yml (lines 19-27), uv is set up first with caching enabled, then Python is configured. Consider reordering to match this pattern and adding enable-cache: true to the uv setup for faster dependency installation. This would align with the repository's established CI patterns and improve workflow performance.

Suggested change
- name: Set up Python 3.13
uses: actions/setup-python@v5
with:
python-version: '3.13'
- name: Set up uv
uses: astral-sh/setup-uv@v4
- name: Set up uv
uses: astral-sh/setup-uv@v4
with:
enable-cache: true
- name: Set up Python 3.13
uses: actions/setup-python@v5
with:
python-version: '3.13'

Copilot uses AI. Check for mistakes.
- name: Install dependencies
run: uv sync --all-extras

- name: Run tests
run: uv run pytest tests/ -v --tb=short
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test command is missing the -n auto flag for parallel test execution. The existing test infrastructure in .github/actions/daily-perf-improver/build-steps/action.yml (line 45) uses pytest tests/ -n auto -v, and the project includes pytest-xdist>=3.0.0 as a dev dependency specifically for parallel testing. Running 26+ test files sequentially will significantly slow down CI feedback. Consider adding -n auto to enable parallel execution: uv run pytest tests/ -n auto -v --tb=short

Suggested change
run: uv run pytest tests/ -v --tb=short
run: uv run pytest tests/ -n auto -v --tb=short

Copilot uses AI. Check for mistakes.
Loading