Address PR review feedback: improve error handling, test clarity, and calculations#86
Merged
abhimehro merged 2 commits intobolt-perf-optimization-14774676592968160940from Jan 18, 2026
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ize calculations Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor rule batch uploads for concurrency in main.py
Address PR review feedback: improve error handling, test clarity, and calculations
Jan 9, 2026
1f9ce9e
into
bolt-perf-optimization-14774676592968160940
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all review comments from PR #73 on the parallelization changes.
Test improvements
test_push_rules_correctness_with_lock→test_push_rules_parallel_with_lockto reflect parallel execution pathtest_push_rules_partial_failureto verify error handling with partial batch failuresError handling
Wrapped
future.result()in try-except to handle unexpected exceptions beyond HTTPError:Performance
Simplified batch count calculation from
len(range(0, len(filtered_hostnames), BATCH_SIZE))to(len(filtered_hostnames) + BATCH_SIZE - 1) // BATCH_SIZE💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.