Merged
Conversation
Implement scrolling for branch selection prompts when the terminal cannot show all matching branches. Add viewport support to `fliptree` as the renderer that owns line-by-line tree output, including scroll marker rendering. Keep `branchtree` as the branch-specific adapter that passes viewport settings through, and keep `BranchTreeSelect` responsible for selection state, filter matching, and choosing the viewport offset. Extend the UI script harness to accept per-script terminal sizes, and add regression coverage for constrained-height scrolling and preserving an already selected branch when filtering still matches it.
Owner
Author
|
This change is part of the following stack: Change managed by git-spice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement scrolling for branch selection prompts
when the terminal cannot show all matching branches.
Add viewport support to
fliptreeas the renderer that owns line-by-line tree output,
including scroll marker rendering.
Keep
branchtreeas the branch-specific adapterthat passes viewport settings through,
and keep
BranchTreeSelectresponsible forselection state, filter matching,
and choosing the viewport offset.
Extend the UI script harness
to accept per-script terminal sizes,
and add regression coverage for
constrained-height scrolling
and preserving an already selected branch
when filtering still matches it.