[expr.prim.splice] Const-ify variable-template splice in contract predicate#13
Open
abhinavagarwal07 wants to merge 1 commit into
Open
[expr.prim.splice] Const-ify variable-template splice in contract predicate#13abhinavagarwal07 wants to merge 1 commit into
abhinavagarwal07 wants to merge 1 commit into
Conversation
…dicate P3598R0 added contract-predicate const-ification to [expr.prim.splice] paragraph 2 for splice-specifier expressions designating variables, but not to paragraph 4's template splice-specialization-specifier form. A variable-template specialization accessed via template [:^^var:]<...> was therefore mutable in a contract predicate, while the same object is const via [:^^var<...>:] or the id-expression var<...>. Name the expression E and apply the same const-ification (using U to avoid clashing with the template T) so all forms agree.
abhinavagarwal07
force-pushed
the
fix-splice-specialization-contract-const
branch
from
fed26a0 to
34a9f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P3598R0 added contract-predicate const-ification to
[expr.prim.splice]paragraph 2 for splice-specifier expressions designating variables, but not to paragraph 4'stemplatesplice-specialization-specifier form. A variable-template specialization accessed viatemplate [:^^var:]<...>is therefore mutable in a contract predicate, while the same object isconstvia[:^^var<...>:](paragraph 2) or the id-expressionvar<...>([expr.prim.id.unqual] p7). Name the expressionEand apply the same const-ification (usingUto avoid clashing with the templateT) so all forms agree.