[mdspan.sub.map.sliceable] Fix M::extent_type to M::extents_type#3
Open
abhinavagarwal07 wants to merge 1 commit into
Open
[mdspan.sub.map.sliceable] Fix M::extent_type to M::extents_type#3abhinavagarwal07 wants to merge 1 commit into
abhinavagarwal07 wants to merge 1 commit into
Conversation
Layout mapping types expose extents_type, not extent_type; the latter is a member of extent_slice. As written, IT and M_rank in the Let clause name an undefined member.
abhinavagarwal07
force-pushed
the
fix-sliceable-extents-type
branch
from
4ec41db to
b861c38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout mapping types expose
extents_type, notextent_type(the latter is a member ofextent_slice). The Let clause in[mdspan.sub.map.sliceable]definesITandM_rankvia the undefined memberM::extent_type, making the subsequent sliceable layout mapping requirements uninterpretable.The same subclause uses
LayoutMapping::extents_type::rank()andSM::extents_type::{rank,index_type}correctly elsewhere.