Conversation
This is the new home of the nhooyr.io/websocket package. Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
|
Let me take a look, thanks for adding as a reviewer |
WalkthroughThe pull request replaces the websocket library dependency from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
7-7: Consider upgrading tov1.8.14(latest)The latest release of
github.com/coder/websocketisv1.8.14, two patch versions ahead of the pinnedv1.8.12. Subsequent releases include a rewrite of how the library handles connection closing and a fix for an unaligned load error on 32-bit architectures. The close-handling rewrite in particular is directly relevant to this library's usage.⬆️ Proposed version bump
- github.com/coder/websocket v1.8.12 + github.com/coder/websocket v1.8.14🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 7, Update the pinned module version for github.com/coder/websocket from v1.8.12 to v1.8.14 in go.mod to pull in the close-handling rewrite and 32-bit unaligned load fix; after editing the version string run `go get github.com/coder/websocket@v1.8.14` (or `go mod tidy`) and run the test suite/build to confirm no breakages.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@go.mod`:
- Line 7: Update the pinned module version for github.com/coder/websocket from
v1.8.12 to v1.8.14 in go.mod to pull in the close-handling rewrite and 32-bit
unaligned load fix; after editing the version string run `go get
github.com/coder/websocket@v1.8.14` (or `go mod tidy`) and run the test
suite/build to confirm no breakages.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
ably/websocket.goably/websocket_internal_test.gogo.mod
|
Is this related to https://ably-real-time.slack.com/archives/CURL4U2FP/p1771849315558089 |
There was a problem hiding this comment.
Pull request overview
Updates the project’s WebSocket dependency to use the new module path (github.com/coder/websocket), which is the new home of the former nhooyr.io/websocket package.
Changes:
- Replaced
nhooyr.io/websocketwithgithub.com/coder/websocketin module requirements. - Updated imports in the Ably WebSocket implementation and internal tests accordingly.
- Refreshed module sums consistent with the dependency change.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Switches required module from nhooyr.io/websocket to github.com/coder/websocket. |
| go.sum | Updates checksums to match the new websocket module path and tidied dependency set. |
| ably/websocket.go | Updates the websocket import and adjusts an error message to reference the new module path. |
| ably/websocket_internal_test.go | Updates test import to the new websocket module path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is the new home of the nhooyr.io/websocket package (see https://coder.com/blog/websocket).
Summary by CodeRabbit