Replace HashBytes manual array impl with min_const_generics#48
Open
BlackHoleFox wants to merge 1 commit into
Open
Replace HashBytes manual array impl with min_const_generics#48BlackHoleFox wants to merge 1 commit into
BlackHoleFox wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When going for a 128 byte image hash, I noticed that the size wasn't actually implemented, even though the doc comment said as such. So, instead of just adding more lengths I tried to just switch it to
min_const_genericsinstead since its been on stable for a while now.If you prefer not to make the MSRV so high I can drop this commit and just add the extra array implementations.