fix #2 by handling out of bounds repeat values#5
Open
fabiosantoscode wants to merge 1 commit intoabrkn:masterfrom
Open
fix #2 by handling out of bounds repeat values#5fabiosantoscode wants to merge 1 commit intoabrkn:masterfrom
repeat values#5fabiosantoscode wants to merge 1 commit intoabrkn:masterfrom
Conversation
fabiosantoscode
force-pushed
the
master
branch
from
b9df0e1 to
0a675bb
Compare
Author
|
The 0.6 tests are failing due to too many C++ compilation warnings (I guess it's compiling node 0.6?) on the console: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2 as well as the issue that I pointed out in a comment, by handling the case where
repeatgoes over 100.Effectively when
repeatgoes over 100, a variable is bumped by 100 to indicate that we're actually generating nonces in the future. This will continue to happen until either the nonce reachesNumber.MAX_SAFE_INTEGERor enough time passes without generating nonces.I could've used the
%operator to make the fix smaller, but opted to use an extra variable to represent how far into the future we're pretending to be since that is a bit more readable.Thanks for being open to PRs :) this package has a nice name and interface and I want to use it in the future :)