Fix msan false positive in the swiss table#2092
Open
AustinSchuh wants to merge 1 commit into
Open
Conversation
The swiss table implementation is well optimized and uses SIMD instructions. This doesn't play well with MSAN. There is already a macro to ignore uninitialized warnings, treat MSAN the same way. Signed-off-by: Austin Schuh <austin.linux@gmail.com>
Contributor
|
Thanks for the PR! Can you add a test case reproducing this problem as well? We don't have MSAN tests for the OSS code atm, but I can verify that internally |
Author
|
Thanks for the prod. I've been trying to isolate this down to a single test I can upstream, and I think I've conflated 2 issues. A decent number of absl tests fail when I'm building optimized with msan, but pass under fastbuild. I think I conflated that with this fix. This makes progress under -c opt, but has probably unintended consequences on fastbuild (ignoring more issues). Happy to close this out if you want. The latest https://github.com/bazel-contrib/toolchains_llvm now has support for building with msan. That's how I'm doing my tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swiss table implementation is well optimized and uses SIMD instructions. This doesn't play well with MSAN. There is already a macro to ignore uninitialized warnings, treat MSAN the same way.