fix(ssl): create certificate output directory - #261
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
Contributor
|
@floze-the-genius rebase and implement this for all certs |
Signed-off-by: Floze <88098863+floze-the-genius@users.noreply.github.com>
floze-the-genius
force-pushed
the
fix/257-create-ssl-certs-dir
branch
from
August 9, 2026 10:40
cf4c054 to
00abf92
Compare
Author
|
@rodneyosodo Rebased onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix.
What does this do?
Closes #257.
A fresh clone does not contain
docker/ssl/certs, so certificate targets fail when their first writer tries to create a file under$(CRT_LOCATION).This adds one idempotent
$(CRT_LOCATION)directory target and makes every currently implemented certificate-producing target (ca,server_cert, andclient_cert) use it as an order-only prerequisite. Existing directories are left untouched, and directory timestamps do not regenerate certificates.The patch is rebased onto current
mainand includes a focused Makefile integration test. Certificate-generation settings and the existing CA dependency of server/client certificates are unchanged.Verification
mainbecause no certificate target scheduled or createdCRT_LOCATION.go test ./docker/ssl -run '^TestMakefile' -count=1 -vPROPELLER_REAL_OPENSSL_TEST=1 go test ./docker/ssl -run '^TestMakefileRealOpenSSLCheckCerts$' -count=1 -vt.TempDir();check-certsrun preserves all four output files.go test -race ./docker/ssl -run '^TestMakefile' -count=1go test ./... -count=1go vet ./...golangci-lint v2.12.2 run --config ./.golangci.yaml— 0 issuesgit diff --checkDocumentation is unchanged because this restores the existing documented setup behavior.