Skip to content

Fix missing dependency#770

Open
lkorth wants to merge 4 commits intoac2cz:masterfrom
lkorth:master
Open

Fix missing dependency#770
lkorth wants to merge 4 commits intoac2cz:masterfrom
lkorth:master

Conversation

@lkorth
Copy link
Copy Markdown

@lkorth lkorth commented Jun 8, 2024

I was compiling and running this and ran into JTransforms missing its dependency on JLargeArrays. This PR adds the jar downloaded from maven. Please don't take my word for this binary and verify it yourself as well.

~/dev/FoxTelem lkorth@master % md5 lib/jlargearrays/JLargeArrays-1.5.jar
MD5 (lib/jlargearrays/JLargeArrays-1.5.jar) = 9e9af6183a8ad44b01b4b76a34a56821
~/dev/FoxTelem lkorth@master % curl -s https://repo1.maven.org/maven2/pl/edu/icm/JLargeArrays/1.5/JLargeArrays-1.5.jar | md5
9e9af6183a8ad44b01b4b76a34a56821

I was also using IntelliJ to run the project so I opted to update the .gitignore to support it's IDE metadata files.

lkorth added 3 commits June 8, 2024 16:25
This is an exact copy of the .project file
Compilation was failing without this dependency required by JTransforms
@ac2cz
Copy link
Copy Markdown
Owner

ac2cz commented Jun 16, 2024

Hi @lkorth , thanks for the pull request. I don't have this missing dependency though. Did you use a later version of JTransforms? I am using Version 3.0.

@lkorth
Copy link
Copy Markdown
Author

lkorth commented Jun 20, 2024

I built it with the dependencies committed in the repo and it appears that the JTransforms jar doesn't include transitive dependencies. I wonder if JLargeArrays is already on your classpath.

dev/FoxTelem/src/decoder/SourceIQ.java:848:12
java: cannot access pl.edu.icm.jlargearrays.DoubleLargeArray
  class file for pl.edu.icm.jlargearrays.DoubleLargeArray not found

upstream:

~/FoxTelem lkorth@master % git show --oneline
8c76f69c (HEAD -> master, origin/master, origin/HEAD) Merge pull request #762 from ac2cz/dependabot/maven/lib/mysql-connector-java-8.0.29/src/build/misc/com.google.protobuf-protobuf-java-3.19.6
~/FoxTelem lkorth@master % git grep DoubleLargeArray
~/FoxTelem lkorth@master % 

vs my fork:

~/dev/FoxTelem lkorth@master % git show --oneline
6e215720 (HEAD -> master, origin/master, origin/HEAD) Fix missing dependency
~/dev/FoxTelem lkorth@master % git grep DoubleLargeArray
Binary file lib/jlargearrays/JLargeArrays-1.5.jar matches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants