Add invalid balance lookup test coverage (#32)#116
Open
haanarrh wants to merge 2 commits intoaccesslayerorg:mainfrom
Open
Add invalid balance lookup test coverage (#32)#116haanarrh wants to merge 2 commits intoaccesslayerorg:mainfrom
haanarrh wants to merge 2 commits intoaccesslayerorg:mainfrom
Conversation
|
@haanarrh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
please kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
creator-keys.get_key_balance,get_total_key_supply, andget_creator_holder_countreturn0for unregistered creators, avoiding panics.get_creator_supplycorrectly returnsErr(ContractError::NotRegistered)for missing creators.get_key_balancewhere the creator is the holder and where the contract address itself is the holder.get_creator_detailsreturns a structured view withis_registered: falseand default field values for unregistered creators.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace(New tests ininvalid_balance_lookups.rsverify all edge cases)Checklist