feat: Keyboard shortcuts to toggle map overlays#646
feat: Keyboard shortcuts to toggle map overlays#646KidVizious wants to merge 2 commits intoaccius:Stagingfrom
Conversation
|
Hey, nice work on this — keyboard shortcuts for layer toggling is a great addition and the dual-mode panel (modal + dockable) is well thought out. A few things I'd like addressed before merging: Bug — Indentation Bug — Removed translation key Concern — Shortcut stability Minor — Global coupling Minor — Static deps on useMemo TL;DR: Fix the indentation and confirm the removed translation key, and this is good to go. The shortcut stability thing can be a follow-up issue. Thanks for putting this together! |
|
I am closing this and adding in the fixes as I wouldn't mind having this in tomorrows prod release. |
|
@accius I implemented your fixes as well as some other improvements if you want to take another look.
|
What does this PR do?
Adds key bindings to toggle map layers on and off. It also adds both a floating panel and dockable panel with the current list of dynamically created keybinds.
Resolves #635
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts includedScreenshots (if visual change)
Some sample screenshots are below. I didn't post every combo for brevity sake.