-
Notifications
You must be signed in to change notification settings - Fork 0
the-ir.md: reconcile §6 with how slices 4/5 of #1187 actually landed #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| level: patch | ||
| changelog: "design/tracks/the-ir.md §6 reconciled with how slices 4/5 of #1187 actually landed (both narrowed hard, not the structural cutovers the table's own row implied) and how Provider and slice 6 (project.rs cleanup) still stand — no Rust code changes" | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"this table's own row" points at the wrong table. This section's table is P6.0–P6.9, and line 398 explicitly says it "is not the cutover decomposition … scoped separately in #1187". It has no
Agentcutover row, noServicerow, no slice-6project.rsrow, and no "trailAgent+Service" row — those all live in #1187's table. Confirmed by grep: neither "residue" (in the(1)–(5)sense) nor "trail" appears anywhere else in this file.The existing slice paragraphs get this right — slice 2 says "narrowed from #1187's own pairing with
runtime_use.rs", slice 3 "narrowed from #1187's own pairing withProvider". Same misattribution recurs at line 472 ("this table's own "once (1)–(5) land …" framing"), line 484 ("this table's own "trailAgent+Service" framing"), and in the pending file'schangelog("the table's own row implied").Suggest matching the established convention, e.g.
not the structural IrItem::Agent cutover #1187's own row implies. For a PR whose whole purpose is making §6 match reality, sending a reader to a table that doesn't contain the framing being corrected is the one thing worth fixing here.