Add place_multiple_adsorbates fn#40
Open
lancekavalsky wants to merge 31 commits into
Open
Conversation
will add when able to do more testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
place_multiple_adsorbatesfunction. It operates in a similar way asplace_adsorbate, but with the added functionality of providing multiple adsorbates to be placed simultaneously (and thus, specifying different locations, heights, anchor atom indices, etc..)The other PR this is based off of (#39) has functions for enumerating the placement of multiple adsorbates at a given coverage as well. But I'd like to do more testing on those functions before we consider merging them