Medical Circulation - Add Acidosis Impacts#373
Open
mazinskihenry wants to merge 17 commits intoacemod:medical/add-circulationfrom
Open
Medical Circulation - Add Acidosis Impacts#373mazinskihenry wants to merge 17 commits intoacemod:medical/add-circulationfrom
mazinskihenry wants to merge 17 commits intoacemod:medical/add-circulationfrom
Conversation
Update ACE_Medical_Core_localization.st
* Added Spanish and Italian translations to all available add-ons. * Adjusted some remaining settings, fixed some translation and capitalization errors. Adjusted the remaining settings (localization configs for all add-ons) and corrected translation and capitalization errors in Spanish and Italian. * Update AUTHORS The contributor name has been sorted in alphabetical order. * Update ACE_localization.st Fixed a duplicated Target (pt_br). * Update ACE_localization.st Deleted duplicated Targets.
mazinskihenry
changed the title
Member
|
Don't forget to add yourself to |
Kexanone
requested changes
Jan 30, 2026
Member
Kexanone
left a comment
Kexanone
left a comment
There was a problem hiding this comment.
As discussed, we should go for pH for quantifying acidosis.
Kexanone
requested changes
Mar 12, 2026
...al_circulation/scripts/Game/ACE_Medical_Circulation/Components/ACE_Medical_VitalsComponent.c
Outdated
Show resolved
Hide resolved
...al_circulation/scripts/Game/ACE_Medical_Circulation/Components/ACE_Medical_VitalsComponent.c
Outdated
Show resolved
Hide resolved
...al_circulation/scripts/Game/ACE_Medical_Circulation/Components/ACE_Medical_VitalsComponent.c
Show resolved
Hide resolved
Kexanone
requested changes
Mar 18, 2026
...circulation/scripts/Game/ACE_Medical_Circulation/FSM/States/ACE_Medical_CardiacArrestState.c
Outdated
Show resolved
Hide resolved
...circulation/scripts/Game/ACE_Medical_Circulation/FSM/States/ACE_Medical_ResuscitationState.c
Outdated
Show resolved
Hide resolved
Kexanone
reviewed
Mar 18, 2026
...circulation/scripts/Game/ACE_Medical_Circulation/FSM/States/ACE_Medical_ResuscitationState.c
Outdated
Show resolved
Hide resolved
...edical_circulation/scripts/Game/ACE_Medical_Circulation/FSM/States/ACE_Medical_IVitalState.c
Outdated
Show resolved
Hide resolved
Kexanone
reviewed
Mar 18, 2026
...edical_circulation/scripts/Game/ACE_Medical_Circulation/FSM/States/ACE_Medical_IVitalState.c
Outdated
Show resolved
Hide resolved
Member
|
General advice for feature-based PRs: Focus on implementing the actual feature, rather than also doing unrelated refactoring and fixes simultaneously. Create separate refactoring PRs instead. This keeps the PRs cleaner and easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Full impact on the increasing side (left) of the plot is 30bpm, creating a decompensated shock effect the longer the patient remains in the ~Class III hemorrhage range. That full impact on the decreasing side (right) of the plot is 50bpm to not drop players into arrest without known injuries and to create more complex patient profiles coming out of existing arrests and hypovolemia. These sides also flip in terms of impacts, so on the increasing side at 1% fluid volume, the time to reach the 30bpm effect is 5min but on the decreasing side at 100% fluid volume, the time to REMOVE the full effect is 5min.
The intended effect is that players who remain at critical fluid levels for long periods of time enter an anaerobic state, represented by acidosis, at which point the heart begins to slow and eventually results in cardiac arrest. This obviously doesn't impact players who have blood regeneration enabled as they can easily shift out of the range where acidosis impacts begin to build up, but nothing to be done about that.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.