Skip to content

Comprehensive Backend and Frontend support for EDF and SET to BIDS Conversion#131

Open
NadaElmasry wants to merge 11 commits intoaces:set2bidsfrom
NadaElmasry:set2bidsv2
Open

Comprehensive Backend and Frontend support for EDF and SET to BIDS Conversion#131
NadaElmasry wants to merge 11 commits intoaces:set2bidsfrom
NadaElmasry:set2bidsv2

Conversation

@NadaElmasry
Copy link

Overview

This PR finalizes the integration of the EEG2BIDS and SET2BIDS backends, alongside their corresponding frontend support. Both backend and frontend components have been thoroughly developed, tested, and validated. The old backend has been successfully deprecated and removed.

This PR builds on the work documented in the draft PR: #129. It has been moved to a new PR for better readability.

Key Changes

  1. Separation of Logic

    • Refactored File Handling: The EDF and SET file handling logic have been encapsulated into distinct classes, each inheriting from the new BaseHandler class. This modular approach enhances code organization, readability, and maintainability.
  2. Backend and Frontend Integration

    • Seamless Integration: Full integration between the backend and frontend ensures that the system operates cohesively, providing a smooth and efficient user experience.
  3. Deprecation of Old Backend

    • Removal of Legacy Code: The old backend has been deprecated and completely removed from the codebase. This eliminates redundancy and reduces maintenance overhead.
  4. Testing

    • End-to-End Validation: Comprehensive end-to-end testing has been performed to validate the seamless interaction between backend and frontend, ensuring that data flows correctly and functionalities perform as expected.

Next Steps

  • Update Project Documentation: Ensure all relevant documentation reflects the new backend and frontend integrations.
  • Unit and Integration Testing: Continue with unit and integration tests to maintain code quality and functionality.

@christinerogers
Copy link
Collaborator

Thanks Nada - Please push your changes this week - they are all trivial looking at the review comments above.
Then we can start testing the developer build, ideally before the holiday break which is coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants