fix(docker): move runtime defaults from CMD to env vars - #20
Merged
Conversation
Docker replaces the whole CMD when the user passes their own args, so the defaults baked into CMD (-gpu cuda, -models /models, -port) were dropped on any override: the CUDA image silently ran CPU inference and the models path fell back to ./models and crashed. Bake the defaults as PARAKEET_* env vars instead, which survive arg overrides. A flag passed on the command line still wins over the env var. Applies to both the CPU and CUDA images. Drops the redundant command block from the docker-compose example. Fixes #15.
achetronic
force-pushed
the
fix/cuda-defaults-from-env
branch
from
July 1, 2026 13:40
672155b to
1db77c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker replaces the whole CMD when the user passes their own args, so the defaults baked into CMD (
-gpu cuda,-models /models,-port) were dropped on any override. The CUDA image silently ran CPU inference, and the models path fell back to./modelsand crashed.Fixes
PARAKEET_*env vars, which survive arg overrides. A flag passed on the command line still wins over the env var.commandblock from the docker-compose example.Relies on the generic flag-to-env mapping merged in #19.
Fixes #15.