refactor: trim dead code and stray comments from the netdev feature - #3
Merged
Conversation
… layers - remove validateNetdev (a constant-nil placeholder kept "for future fields") - drop the Apply comment explaining the planner's per-node decision inside the generic applier; the other sections carry no such comment - tighten the NetdevConfig doc comment to what the type is, not how tunnelctl applies it
achetronic
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup pass over the host-tuning feature.
validateNetdev, a validator that only returned nil and existed "for future fields". Nothing to validate today, so the call and the function are gone.Applythat explained which node carries the netdev section. That is the planner's decision, not the applier's business, and the WireGuard and nftables sections next to it carry no such comment.NetdevConfigdoc comment to say what the type is, leaving out how tunnelctl applies it.No behaviour change. Tests and vet stay green.