Skip to content

os/bluestore: improve stray spanning blobs fix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aclamk merged 4 commits into from
May 28, 2026
Merged

os/bluestore: improve stray spanning blobs fix #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42cb871
test/test_bluestore_types: add prune tail tests
ifed01 May 8, 2026
be93e12
test/unittest_bluestore_types: more tests for blob splitting
ifed01 May 8, 2026
5331252
os/bluestore: enforce blob's tail prunning after splitting.
ifed01 May 8, 2026
52be63c
os/bluestore: avoid iteration over spanning blobs when debug level is
ifed01 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/os/bluestore/BlueStore.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2919,6 +2919,7 @@ void BlueStore::Blob::split(Collection *coll, uint32_t blob_offset, Blob *r)
{
dout(10) << __func__ << " 0x" << std::hex << blob_offset << std::dec
<< " start " << *this << dendl;
ceph_assert(r);
ceph_assert(blob.can_split());
ceph_assert(used_in_blob.can_split());
bluestore_blob_t &lb = dirty_blob();
Expand All @@ -2930,6 +2931,10 @@ void BlueStore::Blob::split(Collection *coll, uint32_t blob_offset, Blob *r)

lb.split(blob_offset, rb);

maybe_prune_tail(); // we might get tail-to-prune after splitting
r->maybe_prune_tail(); // likely redundant (as we tend to prune original blob beforehand)
// but let it be

dout(10) << __func__ << " 0x" << std::hex << blob_offset << std::dec
<< " finish " << *this << dendl;
dout(10) << __func__ << " 0x" << std::hex << blob_offset << std::dec
Expand Down Expand Up @@ -3588,9 +3593,14 @@ BlueStore::ExtentMap::reshard_decision(uint32_t segment_size) {
<< needs_reshard_end << ") segment 0x" << segment_size << std::dec
<< " of " << onode->onode.extent_map_shards.size()
<< " shards on " << onode->oid << dendl;
for (auto& p : spanning_blob_map) {
dout(20) << __func__ << " spanning blob " << p.first << " " << *p.second
<< dendl;
const int span_blob_log_level = 20;
if (cct->_conf->subsys.should_gather<ceph_subsys_bluestore, span_blob_log_level>()) {
for (auto& p : spanning_blob_map) {
dout(span_blob_log_level) << __func__
<< " spanning blob "
<< p.first << " " << *p.second
<< dendl;
}
}
// determine shard index range
unsigned shard_index_begin = 0, shard_index_end = 0;
Expand Down
Loading