fix unit test by capturing the stdout in buffer for compare#5
Open
WheeskyJack wants to merge 3 commits intoacmpesuecc:mainfrom
Open
fix unit test by capturing the stdout in buffer for compare#5WheeskyJack wants to merge 3 commits intoacmpesuecc:mainfrom
WheeskyJack wants to merge 3 commits intoacmpesuecc:mainfrom
Conversation
use io.Writer from pwd cmd so that it can default to stdout and can be set to other writer in unit test to capture the print.
use io.Writer from ls cmd so that it can default to stdout and can be set to other writer in unit test to capture the print.
Update test function with cmd.SetOut to capture the output and fix failing tests
|
Thank you from Opening this Pull Request, @WheeskyJack ! A Maintainer will review it soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi @IshaanNene ,
this pr fixes the failing tests in unit pkg. issues with original tests was it was not correctly capturing the stdout from actual cmd execution. By setting the cmd stdout to test buffer, we can now capture it and use it for cmd.
#2