fix(footer): footer can now run on npm run dev and render images#107
Open
Hnk0406 wants to merge 1 commit intoacmpesuecc:new-sitefrom
Open
fix(footer): footer can now run on npm run dev and render images#107Hnk0406 wants to merge 1 commit intoacmpesuecc:new-sitefrom
Hnk0406 wants to merge 1 commit intoacmpesuecc:new-sitefrom
Conversation
|
Thank you from Opening this Pull Request, @Hnk0406 ! A Maintainer will review it soon! |
Contributor
|
@Hnk0406 the sizes are still inconsistent :( 
|
Author
|
hey so ive been working on it and gotten it to a smaller size |
Contributor
|
@Hnk0406 show me your screenshots on an iPad / mid sized screen using the device mode on your browser dev tools, that's where this styling breaks |
Contributor
|
Make it as responsive as you can please @Hnk0406 |
Author
|
The latest of my code uses hooks to react to every viewport state to give it a custom footer size and it still comes to pretty much the same |
Author
|
I don't have a iPad so I can't completely check that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can render images and run on npm
had to change repo name
running on my device