This repository was archived by the owner on Nov 16, 2021. It is now read-only.
[8.x-4.x] Stale configuration for views.view.frontpage.yml.#666
Merged
phenaproxima merged 1 commit intoacquia:8.x-4.xfrom Dec 19, 2019
Merged
[8.x-4.x] Stale configuration for views.view.frontpage.yml.#666phenaproxima merged 1 commit intoacquia:8.x-4.xfrom
phenaproxima merged 1 commit intoacquia:8.x-4.xfrom
Conversation
danepowell
force-pushed
the
stale-config-2
branch
from
d479be1 to
9a0a451
Compare
Collaborator
|
Thanks, @danepowell. I'm in favor of this. Would you be willing to open a separate pull request for 8.x-3.x? It won't cherry-pick cleanly. |
phenaproxima
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lightning_alter_frontpage_view() in lightning.profile dynamically modifies the views.view.frontpage.yml configuration at install time.
The problem is that it does so using an outdated Views configuration schema. Views has made some modifications recently such as adding the
operator_limit_selectionkey and removing thecorekey.This causes configuration to appear perpetually overridden after an initial install, which is going to confuse people and cause problems for CI tools that expect a clean configuration state.