#12891: Fixed issue for Cuctom object for country filter#376
Closed
dhirendramishra10 wants to merge 2 commits intostagingfrom
Closed
#12891: Fixed issue for Cuctom object for country filter#376dhirendramishra10 wants to merge 2 commits intostagingfrom
dhirendramishra10 wants to merge 2 commits intostagingfrom
Conversation
avikarshasaha
requested changes
Nov 24, 2025
|
|
||
| public function evaluateFilters(ContactFiltersEvaluateEvent $event): void | ||
| { | ||
| // 2. Normalize only Custom Object filters |
| } | ||
|
|
||
| // Case B: Reverse format (value => label) | ||
| $reversed = array_flip($options); |
Contributor
There was a problem hiding this comment.
$value = array_search($label, $options, true);
if ($value !== false) {
$filter['filter_value'] = $value;
}
Contributor
There was a problem hiding this comment.
array_flip is expensive operation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming that:
a = current major release
b = current minor release
c = future major release
Description:
Steps to Reproduce:
Steps to test this PR: