Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 75.76% 74.41% -1.36%
==========================================
Files 58 63 +5
Lines 3326 3709 +383
Branches 167 181 +14
==========================================
+ Hits 2520 2760 +240
- Misses 701 844 +143
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
drmorr0
left a comment
There was a problem hiding this comment.
You can test how this will actually appear on the web by changing the branch name in the www repo to point to your branch:
https://github.com/acrlabs/www/blob/main/simkube.yml#L70
Then on your laptop you can run just run simkube and see the whole website at localhost:8001 (sadly the live updates thing doesn't work for the cross-repo docs, though, so when you make changes you have to push them to your branch, kill the mkdocs process, and restart it).
docs/mkdocs.yml
Outdated
| - Overview: docs/infra/overview.md | ||
| - Amazon Machine Images (AMI's): docs/infra/amis.md | ||
| - Using SimKube AMIs: docs/infra/usage.md | ||
| - Custom GithHub Action Runners: docs/infra/github-runners.md |
There was a problem hiding this comment.
These headings are probably going to be too long for the sidebar if I had to guess
docs/mkdocs.yml
Outdated
| - sk-ctrl: docs/components/sk-ctrl.md | ||
| - sk-driver: docs/components/sk-driver.md | ||
| - sk-tracer: docs/components/sk-tracer.md | ||
| - Infrastructure: |
There was a problem hiding this comment.
I don't like the name "Infrastructure" here -- something like "Prebuilt Simulation Environments" is closer to what I want, but that might be too long for the sidebar.
Did that and caught a few more errors! |
Oh! I've got it. Instead of "Prebuilt Simulation Environments", call it "SimKube in the Cloud" |
| |:-----------------------------------------------|:-----------:|:-------------------------:| | ||
| | Ubuntu 24.04 LTS Operating System | ✅ | ✅ | | ||
| | A running Kubernetes cluster & management tools| ✅ | ✅ | | ||
| | All SimKube components* | ✅ | ✅ | |
There was a problem hiding this comment.
I think maybe remove the asterisk here?
| ``` | ||
|
|
||
| You will need to generate an pair of access tokens for in AWS for the IAM user you are using to access AWS resources. Hang onto those you will need them when you configure the secrets. | ||
| You will need to generate a `key pair` in AWS for the IAM user you are using to access AWS resources. Hang onto those; you will need them when you configure the secrets. |
There was a problem hiding this comment.
I don't think "key pair" should be in backticks.
| ## 5. Evaluating your results | ||
| Prometheus and Grafana are installed natively. Users can view simulation results by connecting to the Grafana pod on your EC2 instance. | ||
|
|
||
| See [Evaluate your results](./evaluate.md). |
There was a problem hiding this comment.
See "Evaluate your results" for more details.
| ``` | ||
|
|
||
| ## 1. Open the Grafana UI | ||
| <http://localhost:3000/> |
There was a problem hiding this comment.
In order to actually make this work (since your EC2 instance is headless) you need to tunnel traffic from your localhost to the EC2 instance, using something like
ssh -L <LOCAL_PORT>:<REMOTE_HOST>:<REMOTE_PORT> <ec2-instance-ip>
And then you can connect to https://localhost:<LOCAL_PORT> to view the grafana dashboard.
|
|
||
| ## Assumptions | ||
| - you have collected a trace from the cluster you want to simulate, if you still need to do this see [the sk-tracer docs](../components/sk-tracer.md). | ||
| - you have collected a trace from the cluster you want to simulate, if you still need to do this see [the sk-tracer docs](https://github.com/acrlabs/simkube/blob/main/docs/intro/running.md). |
There was a problem hiding this comment.
I don't think we want the github.com link here, this should just be ../intro/running.md?
|
|
||
| > [!NOTE] | ||
| > `simkube-ci-action` runners are epehmeral-only and all data from the simulation is lost. | ||
| > In the future we expect to expose functionality that will allow data to be sent to external prometheus endpoints. |
| ## Assumptions | ||
| - you have collected a trace from the cluster you want to simulate, if you still need to do this see [the sk-tracer docs](https://github.com/acrlabs/simkube/blob/main/docs/intro/running.md). | ||
|
|
||
| [TODO] MOVE TO usage and link to that. Add full IAM policy JSON to examples/aws/ |
| > For simplicity and ease of use, we recommend using AWS S3 to store your trace files. | ||
| > If your trace files are in S3, you can skip this step; SimKube will need additional IAM permissions to access your S3 bucket. | ||
|
|
||
| Copy your trace to the instance, the default SimKube trace location is /data/trace: |
There was a problem hiding this comment.
Should be /var/kind/cluster/trace, also enclose the path in backticks
| Copy your trace to the instance, the default SimKube trace location is /data/trace: | ||
|
|
||
| ```sh | ||
| scp your_trace_file ubuntu@<instance-ip>:/var/kind/<cluster-name>/trace |
There was a problem hiding this comment.
The AMI uses the default cluster name, right? It's just cluster? So we should probably specify the default/absolute path here.
| @@ -0,0 +1,39 @@ | |||
| { | |||
There was a problem hiding this comment.
Are you planning to link to this from somewhere?
The other option that might be better is to actually just embed this as a page in the "Reference" section. You can see other examples of embedding files, for example, here

Related Links
Description and Rationale
Drafts of a few docs for AMIs, I called this section
Infrastructurebut would love a suggestion:overview.md- a basic rundown of offeringsamis.md- a little more detail on the AMIs, I expect this page to grow more over time?usage.md- high level how to find/use the AMIsgithub-runners.md- high level using the SimKube Action Runner AMIrun-sim.md- basic how to run a sim on EC2ci-sim.md- basic how to setup ci runners using GitHub actions andsimkube-ci-actionHow
Test Steps
Other Notes
I could use some help calibrating this, it feels... verbose but also I expect most people will just go to the quickstart stuff?
[ x ] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.