Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Field of View (Divided Attention Task) game plugin to the BrainSpeedExercises Electron app, including its UI/controller layer, pure game logic, styling, and Jest tests, plus a small update to the game-selection card to surface the game’s best threshold metric.
Changes:
- Introduce the
field-of-viewgame plugin (manifest, UI HTML, CSS, controllerindex.js, pure logicgame.js, and tests). - Update the game card component + tests to display “All-time Best Threshold” for Field of View progress data.
- Adjust the visible app header/footer text in
app/index.html.
Reviewed changes
Copilot reviewed 9 out of 16 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| app/index.html | Updates visible branding text in header/footer. |
| app/components/gameCard.js | Adds Field of View-specific progress rendering (“best threshold”). |
| app/components/gameCard.test.js | Adds tests for Field of View progress rendering on game cards. |
| app/games/field-of-view/manifest.json | Registers the new Field of View game with the plugin registry. |
| app/games/field-of-view/interface.html | Adds the game’s injected UI fragment (instructions, play area, trend chart, end panel). |
| app/games/field-of-view/style.css | Adds scoped styling for the game UI and response controls. |
| app/games/field-of-view/index.js | Implements the plugin controller (timing loop, rendering, progress persistence, lifecycle). |
| app/games/field-of-view/game.js | Implements pure game logic (staircase, trial generation, metrics). |
| app/games/field-of-view/tests/game.test.js | Unit tests for the pure game logic module. |
| app/games/field-of-view/tests/index.test.js | Integration tests for the plugin lifecycle + DOM behavior. |
|
@copilot open a new pull request to apply changes based on the comments in this thread. You handle all code updates and assume I will replace the images with more compressed versions in a separate effort. Also ignore the comment that starts: "start() unhides the response panel immediately, which allows the player to select the center kitten while the stimulus is still visible." Address all other issues raised in the review. |
…labels, audio context, game logic validation Co-authored-by: acrosman <2972053+acrosman@users.noreply.github.com> Agent-Logs-Url: https://github.com/acrosman/BrainSpeedExercises/sessions/550ed7f7-9f1e-42b0-91bb-31cec38618ae
… shifts Co-authored-by: acrosman <2972053+acrosman@users.noreply.github.com> Agent-Logs-Url: https://github.com/acrosman/BrainSpeedExercises/sessions/adc8dc8c-bc12-402a-bdd6-6c45bc00a4a5
Field of View: address PR review feedback
A The Divided Attention Task game called field of view.
Goal: Identify a central object while localizing a peripheral one.
Based on a spec provided by Gemini.