[IMP] kwkhtmltoimage#31
Open
ah-obs wants to merge 2 commits intoacsone:masterfrom
Open
Conversation
Open
Member
|
Hi, I had not noticed this PR, sorry for the delay. Thanks a lot for it! Do you think it could be possible to factor out common code between the two go clients and add some test coverage? I have to ask, because I'll need to maintain that going forward. |
|
Hi! I’d like to resume this PR. I’ll update it by:
I’ll open a continuation PR referencing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the functionality for kwkhtmltoimage. Odoo need this for some spreadsheets for example
Changed the path for the pdf generation to "/" and "/pdf" and added the path for the image generation "/image"
closes #22