Feature/prometheus#39
Conversation
| google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw= | ||
| google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc= | ||
| google.golang.org/protobuf v1.31.0 h1:g0LDEJHgrBl9N9r17Ru3sqWhkIx2NB67okBHPwC7hs8= | ||
| google.golang.org/protobuf v1.31.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I= |
There was a problem hiding this comment.
That's really a lot of dependencies to emit a 4 lines metrics.
Dependencies would need to be managed, upgraded etc. That sounds like a lot of burden for little benefit. Would the code be much more complicated without them?
There was a problem hiding this comment.
Makes sense, I agree.
I mostly opened the PR to move the discussion forward and have something concrete to look at, but you're right that pulling all those dependencies just for a few metrics is probably overkill.
I can rework this to expose metrics manually in Prometheus format without external dependencies.
az-adhoc
force-pushed
the
feature/prometheus
branch
from
1877f0b to
5bd5b3d
Compare
|
@sbidoul Something like this? 🙂 I ran all the tests locally and it seems to work fine. If you're OK with this approach, we can figure out together how to add tests for it. |
az-adhoc
force-pushed
the
feature/prometheus
branch
from
5bd5b3d to
0f57fbb
Compare
|
@sbidoul Let me know if you want any more changes. |
az-adhoc
force-pushed
the
feature/prometheus
branch
from
0f57fbb to
3601eaf
Compare
3 participants
Hi!
This PR addresses #33 and is based on the approach introduced in #38
This is an initial implementation intended to gather feedback and align on the design before refining it further.
Happy to iterate based on your suggestions.