Conversation
|
@gnunicorn |
|
I left it in draft, as the server isn't reliably up yet and the client would stop functioning/block right now. So I first want to tackle the offline-ability and then maybe go towards merging... |
|
@kumarpalsinh25 okay, we now have an offline aware client and I think that means we can merge this in and start playing with the actual native interface ... |
kumarpalsinh25
left a comment
There was a problem hiding this comment.
Many of the code I don't understand but I tried to review flutter or we can say dart code. Everything looks fine to me in general.
|
|
||
| // ignore_for_file: unused_import, unused_element, unnecessary_import, duplicate_ignore, invalid_use_of_internal_member, annotate_overrides, non_constant_identifier_names, curly_braces_in_flow_control_structures, prefer_const_literals_to_create_immutables, unused_field | ||
|
|
||
| import 'api/client.dart'; |
There was a problem hiding this comment.
Do we need to submit generated files to git?
There was a problem hiding this comment.
I am not 100% sure about that, but I think that's the idea of the tool, because otherwise you'd have to run a manual CLI after every checkout, and all other things are directly included to be run
This moves the rust part into a separate package in
packages/zoe_nativefor a cleaner separation of concerns. In that new package thisLook, the user id is directly derived from the natively provided internal encryption keypair \o/ .
The new integration platform (flutter rust bridge) we are using has several advantages, which is why we want to use that as closely as possible. In particular it allows for direct mapping of the rust types into dart types in a static typed manner - neat! As a result most models will directly be managed and provided by the package and so will the the riverpod providers. One reason we can allow for that is the API allows for being mocked as well, so we can still do all the nice and fancy testing with nice mocking while also being sure that the types match statically - how awesome is that?!?
So, there was a few bugs in actually connecting to the server(s). Since I first wrote this a few updates have happened that are now included:
See it in action:
systems-check-in-zoe.mp4