Update GitHub Pages action to version 5#414
Open
guoyunhe wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the documentation for the actions/deploy-pages action to reference the new major version in the recommended workflow snippet.
Changes:
- Update the README “Usage” example to use
actions/deploy-pages@v5.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v4 # or specific "vX.X.X" version tag for this action | ||
| uses: actions/deploy-pages@v5 # or specific "vX.X.X" version tag for this action |
There was a problem hiding this comment.
The README now recommends actions/deploy-pages@v5, but the later Compatibility table only lists versions up to v4. To avoid confusing users (especially GHES users), update the table to include v5 (or clarify why v5 is recommended while only v4/older are documented for compatibility).
Suggested change
| uses: actions/deploy-pages@v5 # or specific "vX.X.X" version tag for this action | |
| uses: actions/deploy-pages@v5 # or a specific "vX.X.X" version tag; for GHES, use a version listed in the compatibility table below |
|
Does this block the nodejs upgrade? If yes, please review and merge to progress the nodejs update, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.