Skip to content

feat(comparison): highlight -- WARNING SQL lines and drop-create banner (#2872)#838

Open
actiontech-bot wants to merge 3 commits into
mainfrom
hive-compare-2872
Open

feat(comparison): highlight -- WARNING SQL lines and drop-create banner (#2872)#838
actiontech-bot wants to merge 3 commits into
mainfrom
hive-compare-2872

Conversation

@actiontech-bot
Copy link
Copy Markdown
Member

Summary

For the Hive structure compare flow (issue actiontech/sqle-ee#2872):

  • ModifiedSqlAuditResult.List: detect -- WARNING: lines in modify SQL and render them with a distinct warning-highlight-line className
  • ModifiedSqlDrawer: surface a drop-create warning banner when any modify SQL contains WARNING lines
  • warningSql util: shared isWarningLine / sqlHasWarningLine helpers
  • bilingual i18n keys (zh-CN / en-US) for the new banner
  • jest tests for the ModifiedSqlDrawer WARNING render path

Fixes #2872 (actiontech/sqle-ee)
Refs design.md §3.5 (UI-1/UI-2/UI-3, compat-RISK-6)

@github-actions
Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 80.97% 29500/36435
🟡 Branches 63.27% 11057/17476
🟢 Functions 84.44% 9946/11779
🟢 Lines 84.95% 28186/33180

Test suite run success

3747 tests passing in 816 suites.

Report generated by 🧪jest coverage report action from 3870a84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants