feat(sql_workbench): ODC workbench support for GoldenDB#610
Merged
Conversation
… check #814 - Add GoldenDB -> MYSQL mapping in convertDBType(), consistent with TDSQL For InnoDB approach (MySQL protocol compatible) - Add DBTypeGoldenDB to SupportDBType() so GoldenDB datasources enter ODC sync and EE provision flows - Add unit test cases for both functions covering GoldenDB
…equests GoldenDB does not provide the information_schema database that ODC defaults to for MySQL-type connections, causing datasource status to be INACTIVE. Add DefaultSchema field to CreateDatasourceRequest, UpdateDatasourceRequest and datasourceBaseInfo so DMS can explicitly specify a default schema when syncing datasources to ODC. This change is paired with an ODC-side fix that stops hardcoding information_schema as the default schema for all MySQL-dialect types. Refs: actiontech/dms-ee#814
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
BugsGuru
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Fixes https://github.com/actiontech/dms-ee/issues/814
Summary
Description
为数据源请求结构添加 DefaultSchema 字段
更新数据源基础信息传递 DefaultSchema
扩展数据库类型映射,GoldenDB 映射为 MYSQL
新增 GoldenDB 类型支持的单元测试
Diagram Walkthrough
File Walkthrough
sql_workbench_client.go
添加 DefaultSchema 字段到数据源请求internal/sql_workbench/client/sql_workbench_client.go
sql_workbench_service.go
更新数据源基础信息及数据库类型映射internal/sql_workbench/service/sql_workbench_service.go
buildUpdateDatasourceRequest 中传递 DefaultSchema
sql_workbench_service_test.go
新增 GoldenDB 测试用例internal/sql_workbench/service/sql_workbench_service_test.go