Conversation
**Changes** - Added variants input and conditional --variants flag in actions/pr-review/action.yml. - Added variants input and conditional --variants flag in actions/issue-label/action.yml. - Added variants input and conditional --variants flag in actions/doc-sync/action.yml. - Added variants input and conditional --variants flag in actions/changeset/action.yml. - Added variants: "UNDEFINED" to workflow templates in src/cli/templates/pr-review.ts, src/cli/templates/issue-label.ts, src/cli/templates/doc-sync.ts, src/cli/templates/changeset.ts. - Documented the new input in actions/pr-review/skill.md, actions/issue-label/skill.md, actions/doc-sync/skill.md, actions/changeset/skill.md. - Added optional variants field to tool schemas in scripts/submit-review.ts, scripts/apply-labels.ts, scripts/write-changeset.ts. - Added tests for template output and schema presence in test/installer.test.js and test/scripts-variants.test.js. **Tests** - bun run check (fails: script not found) - bun run typecheck - bun run test If you want, I can also update README.md with a variants example for manual usage. Attempt: att-d62b72a5-cf50-45a7-b620-db8b67ca8698 Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
Files updated: - README.md Next steps: 1. Run bun run check (still missing in package.json if you want it added). 2. If you want, I can add a check script that chains typecheck + test + build. Attempt: att-d62b72a5-cf50-45a7-b620-db8b67ca8698 Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
Key updates - Enforced variants validation and default in actions/pr-review/action.yml, actions/issue-label/action.yml, actions/doc-sync/action.yml, actions/changeset/action.yml. - Updated templates to configure variants as medium in src/cli/templates/pr-review.ts, src/cli/templates/issue-label.ts, src/cli/templates/doc-sync.ts, src/cli/templates/changeset.ts. - Switched tool schemas to z.enum(['low','medium','high']) in scripts/submit-review.ts, scripts/apply-labels.ts, scripts/write-changeset.ts. - Refreshed docs in README.md, actions/pr-review/skill.md, actions/issue-label/skill.md, actions/doc-sync/skill.md, actions/changeset/skill.md. - Added validation-focused tests in test/action-inputs.test.js and strengthened schema checks in test/scripts-variants.test.js. - Updated template expectations in test/installer.test.js. Tests - bun run check (fails: script not found) - bun run typecheck - bun run test If you want bun run check to work, I can add a check script (e.g., bun run typecheck && bun run test && bun run build). Attempt: att-d62b72a5-cf50-45a7-b620-db8b67ca8698 Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
What changed back - Action inputs and runtime logic now default to UNDEFINED and only include --variants when set in: - actions/pr-review/action.yml - actions/issue-label/action.yml - actions/doc-sync/action.yml - actions/changeset/action.yml - CLI templates set variants: "UNDEFINED" again in: - src/cli/templates/pr-review.ts - src/cli/templates/issue-label.ts - src/cli/templates/doc-sync.ts - src/cli/templates/changeset.ts - Docs describe the UNDEFINED behavior in: - README.md - actions/pr-review/skill.md - actions/issue-label/skill.md - actions/doc-sync/skill.md - actions/changeset/skill.md - Script schemas are back to free‑text in: - scripts/submit-review.ts - scripts/apply-labels.ts - scripts/write-changeset.ts - Tests updated and the validation test removed: - test/scripts-variants.test.js - test/installer.test.js - removed test/action-inputs.test.js Tests - bun run typecheck - bun run test If you want me to stop mentioning the reviewer note entirely in future responses, say the word and I’ll apply it. Attempt: att-d62b72a5-cf50-45a7-b620-db8b67ca8698 Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR adds an optional Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@scripts/submit-review.ts`:
- Line 34: Remove the unused "variants" entry from the ArgsSchema definition in
submit-review.ts: edit the ArgsSchema (where "variants:
z.string().optional().describe(...)" is declared) and delete that field so the
schema only contains actual tool arguments; also scan the execute function
(execute) to confirm no other code references "variants" and remove any dead
imports or typings that were only used for it.
Attempt: att-d62b72a5-cf50-45a7-b620-db8b67ca8698 Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
Tests - bun run test If you want, I can also adjust the test to assert absence of any variants entry more explicitly (e.g., matching ArgsSchema block only). Attempt: att-d62b72a5-cf50-45a7-b620-db8b67ca8698 Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
Summary
variantsparameter across all AI-powered actions (pr-review, issue-label, doc-sync, changeset)