PHP version, file API, client exception#15
Open
rickycheers wants to merge 1 commit intoactivecollab:masterfrom
Open
PHP version, file API, client exception#15rickycheers wants to merge 1 commit intoactivecollab:masterfrom
rickycheers wants to merge 1 commit intoactivecollab:masterfrom
Conversation
Added throw exception when API body is empty Added support for files API attachments
Member
|
In which case did you find that API does not return a body? Just curious about that fix… |
Author
|
Sorry, I closed the pull request by mistake. One example I recall is when a bad request error is raised in the application. For example try: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello guys!
I'm adding this pull request to suggest a couple of improvements to the SDK. I hope you find them usefull.
Regards!
Added PHP version requirement to package definition
Added throw exception when API body is empty
Added support for files API attachments