Add omniroute to project setup as a devDependency - #22
Draft
ada33-arch wants to merge 1 commit into
Draft
Conversation
Pin omniroute ^3.8.49 in devDependencies so `npm install` provides it for every clone and CI run, rather than relying on a global install that has to be repeated per machine. Adds an `npm run omniroute` script and a README section covering usage. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HwGPKTnoFc8gkpCPrAKuho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes omniroute a persistent part of the project setup instead of a one-off
npm install -g omniroute.package.json— pinsomnirouteat^3.8.49underdevDependencies, and adds anomniroutenpm script.package-lock.json— regenerated to lock the resolved tree.README.md— new "OmniRoute" section documentingnpm run omniroute/npx omniroute.Why
A global install lives outside the repo: it has to be repeated on every machine, isn't version-pinned, and CI never sees it. As a devDependency the tool comes along with the existing
npm installstep already documented in the README, at a locked version, for every clone.Verification
npx omniroute --version→3.8.49, resolved fromnode_modules/.bin/omniroutenpm run typecheck→ passes (exit 0)Notes for the reviewer
Two things worth a look before this leaves draft:
package-lock.jsongrows by roughly 19k lines. That is the real cost of vendoring this into a repo that currently has three devDependencies.npm installreports 8 vulnerabilities in the new tree (1 low, 2 moderate, 5 high). I did not runnpm audit fix— the fixes may involve breaking upgrades, and that call belongs to you. GitHub also flagged 2 pre-existing vulnerabilities onmainthat are unrelated to this change.There are also peer-dependency warnings during install (
react@18.3.1via@emoji-mart/react, andmarked@18againstmarked-terminal's>=1 <16range). npm resolves both with nested copies; nothing fails.Generated by Claude Code