skip updating text if it's the same in bitmap_label#238
Merged
Conversation
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 7, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 5.0.4 from 5.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#238 from FoamyGuy/fix_same_text_regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression that I think was introduced during the 4.0 refactor that combined outline, scrolling, and accent into bitmap_label.
bitmap_label used to defer to LabelBase.text setter property which has a check to ignore values that are the same as the current text here:
Adafruit_CircuitPython_Display_Text/adafruit_display_text/__init__.py
Lines 450 to 451 in 438f8c7
The refactored version lacked that same check, I noticed it while working on my current project. When the text gets updated over and over in a tight loop it causes it to flicker on the display.
Resolves it by using the same logic inside bitmap label text property setter.