Add MacroPad RP2040 u2if Detection#185
Merged
caternuson merged 4 commits intoadafruit:mainfrom Oct 14, 2021
Merged
Conversation
Contributor
|
@ladyada Can we offer up a new PID for this? We came up with new ones for Feather, Itsy, etc. as I remember: Adafruit_Python_PlatformDetect/adafruit_platformdetect/board.py Lines 479 to 490 in 00db106 |
Member
|
@caternuson yeah do you have access/know how to assign a new PID? |
Contributor
|
@ladyada I do not. |
Member
|
@dhalbert can illuminate it for ya! |
329348e to
30144d6
Compare
Contributor
|
@caternuson Use 0x239A/0x0107 for MacroPad u2if. We mistakenly assigned this to bootloader, but like other RP2040's it has its own due to the ROM bootloader. |
…atformDetect into add_macropad_rp2040
caternuson
requested changes
Oct 13, 2021
Contributor
|
@jfurcean One quick change and I think we can merge. Tested this locally with a MacroPad loaded with new U2IF firwmare. All works as expected. |
caternuson
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds detection for the MacroPad RP2040 u2if. It needs a new USB PID before it can be merged. The PR execuc/u2if#7 should be merged before this one as well. @caternuson