Allow to run non-Development Editor + few minor fixes in the same code#63
Open
sleeptightAnsiC wants to merge 2 commits intoadamrehn:masterfrom
Open
Allow to run non-Development Editor + few minor fixes in the same code#63sleeptightAnsiC wants to merge 2 commits intoadamrehn:masterfrom
sleeptightAnsiC wants to merge 2 commits intoadamrehn:masterfrom
Conversation
…a EpicLauncher and return different results based on it. This was created based on table from https://docs.unrealengine.com/5.3/en-US/build-configurations-reference-for-unreal-engine/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @adamrehn ,
I fixed the suport for launching non-Development Editor #56 There are also few other changes and fixes added by this PR, as they were either easy to fix, located in the same code or blocking me from fixing the mentioned issue. I tested it mostly on Linux but it should work™ on other platforms too since the underlying code was already there.
I also tried to deal with #61 and #62 but they don't seem worth fixing right now (see the comments under those issues). Though, some changes were made with those in mind.
Let me know what do you think. PR is open for your edits.
Cheers!
All changes:
ue4 run DebugGameandue4 editor DebugGameas both these commands now take[CONFIGURATION]as optional parametervalidBuildTargetshelper function that behaves similar asvalidBuildConfigurationsgetBuildScriptas this was not handled anywhere unlike build configurationvalidBuildTargets/Configurationsnow take into consideration if UE is installed via EpicLauncher or not (now the behavior lines up with the tables on this page)getBuildScriptas this was fairly easy to add was surprisingly not supported