Optimize Decoder: Replace string concatenation loops with array/implode - #13
Closed
adapik wants to merge 1 commit into
Closed
Optimize Decoder: Replace string concatenation loops with array/implode#13adapik wants to merge 1 commit into
adapik wants to merge 1 commit into
Conversation
Replace inefficient string concatenation in loops with array append and implode pattern. This changes O(n²) string operations to O(n). - In parseBinaryIdentifier(): collect identifier octets in array then implode once instead of concatenating in loop - In parseContentLength(): collect length octets in array then implode once instead of concatenating in loop This optimization is especially beneficial when parsing long-form identifiers and content lengths, which are common in X.509 and complex ASN.1 structures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace inefficient string concatenation in loops with array append and implode pattern. This changes O(n²) string operations to O(n).
This optimization is especially beneficial when parsing long-form identifiers and content lengths, which are common in X.509 and complex ASN.1 structures.