Fix: Resolve circular dependency deadlock with content module#93
Merged
Conversation
contentplugin.init() awaited the content module, but content.init() also awaits contentplugin, causing both modules to deadlock and timeout. Use .then() for the content hook tap so contentplugin can signal ready without waiting for content. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Removed duplicate tap calls for postInstallHook and postUpdateHook.
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
await this.app.waitForModule('content')ininit(), but thecontentmodule also awaitscontentpluginduring its init, creating a circular deadlock where neither module can signal readyawaitwith.then()so thepreInsertHooktap happens asynchronously aftercontentis ready, allowingcontentpluginto complete init and break the cycleTest plan
DEP_TIMEOUTforadapt-authoring-content🤖 Generated with Claude Code