Skip to content

Fix: prevent sets created from query intersections from triggering events and running unsuitable methods #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverfoster merged 2 commits into from
Jul 10, 2025
Merged

Fix: prevent sets created from query intersections from triggering events and running unsuitable methods #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d52f40
Fix: stop restored event trigger for subsets created from query inter…
danielghost Mar 10, 2025
e604d92
Added early method returns if the set has been created via query inte…
danielghost Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions js/ScoringSet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ export default class ScoringSet extends Backbone.Controller {
this._title = title;
this._isScoreIncluded = _isScoreIncluded;
this._isCompletionRequired = _isCompletionRequired;
// only register root sets as subsets are dynamically created when required
if (!this.subsetParent) this.register();
this.register();
Comment thread
oliverfoster marked this conversation as resolved.
this._setupListeners();
}

Expand All @@ -56,6 +55,7 @@ export default class ScoringSet extends Backbone.Controller {
* @fires Adapt#scoring:set:register
*/
register() {
if (this.subsetParent) return;
Adapt.scoring.register(this);
Adapt.trigger(`scoring:${this.type}:register scoring:set:register`, this);
}
Expand All @@ -64,6 +64,7 @@ export default class ScoringSet extends Backbone.Controller {
* @protected
*/
_setupListeners() {
if (this.subsetParent) return;
if (OfflineStorage.ready) return this.restore();
this.listenTo(Adapt, 'offlineStorage:ready', this.restore);
}
Expand All @@ -75,6 +76,7 @@ export default class ScoringSet extends Backbone.Controller {
* @fires Adapt#scoring:set:restored
*/
restore() {
if (this.subsetParent) return;
Adapt.trigger(`scoring:${this.type}:restored scoring:set:restored`, this);
}

Expand Down Expand Up @@ -102,6 +104,7 @@ export default class ScoringSet extends Backbone.Controller {
* @fires Adapt#scoring:set:reset
*/
reset() {
if (this.subsetParent) return;
Adapt.trigger(`scoring:${this.type}:reset scoring:set:reset`, this);
Logging.debug(`${this.id} reset`);
this._resetObjective();
Expand Down Expand Up @@ -445,6 +448,7 @@ export default class ScoringSet extends Backbone.Controller {
* @fires Adapt#scoring:set:complete
*/
onCompleted() {
if (this.subsetParent) return;
Adapt.trigger(`scoring:${this.type}:complete scoring:set:complete`, this);
Logging.debug(`${this.id} completed`);
this._completeObjective();
Expand All @@ -455,6 +459,7 @@ export default class ScoringSet extends Backbone.Controller {
* @fires Adapt#scoring:set:passed
*/
onPassed() {
if (this.subsetParent) return;
Adapt.trigger(`scoring:${this.type}:passed scoring:set:passed`, this);
Logging.debug(`${this.id} passed`);
}
Expand Down
Loading