Update: align unavailable objectives logic with ScoringSet#17
Merged
oliverfoster merged 1 commit intomasterfrom Nov 6, 2025
Merged
Update: align unavailable objectives logic with ScoringSet#17oliverfoster merged 1 commit intomasterfrom
ScoringSet#17oliverfoster merged 1 commit intomasterfrom
Conversation
oliverfoster
approved these changes
Nov 6, 2025
github-project-automation
Bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
danielghost
added a commit
to adaptlearning/adapt-contrib-scoring
that referenced
this pull request
Apr 2, 2026
…ntrib-scoringAssessment#17. Resolved reset issues as the objective needs to wait until the set has been reset before updating the score and status - adjusted methods and logic accordingly so score and status can be handled separately by the sets lifecycle methods.
danielghost
added a commit
that referenced
this pull request
Apr 2, 2026
… with super class methods not always being called for `onInit` and `onRestore`. Updated to latest Lifecycle logic to distinguish between first attempt and reset attempts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
Fix
Update
ScoringSetDependency