Breaking: Upgrade to version 2 of scoring (fixes #21)#22
Open
oliverfoster wants to merge 20 commits intomasterfrom
Open
Breaking: Upgrade to version 2 of scoring (fixes #21)#22oliverfoster wants to merge 20 commits intomasterfrom
oliverfoster wants to merge 20 commits intomasterfrom
Conversation
Resolved an issue where a second assessment attempt failed to trigger completion. This occurred because `Attempt.isInSession` was reset when `LifecycleRenderer` called `onStart` after `onVisit` following an assessment reset. Moved `isInSession` logic into `AssessmentSet`, as it represents navigation state rather than attempt-specific state. Also removed an unnecessary condition in the Attempts `reset` method that incorrectly set `_history` to an `Attempt`, which was unreachable due to required config.
…Percent` and `resetType` (fixes #24).
…ter()` takes no arguments.
danielghost
reviewed
Mar 18, 2026
… may not be consistent based on conditional content such as branching or banking. This is also needed for the changes made in 20dcb0b. Fixed potential issues due to the incorrect logical operators.
danielghost
reviewed
Apr 1, 2026
| async onVisit() { | ||
| this._isInSession = true; | ||
| if (this.attempt.isInProgress) return; | ||
| if (this._isInReset) return; |
Contributor
There was a problem hiding this comment.
Is it actually possible for the set to already be in a reset phase at this point with the way the LifeCycleRenderer works?
Member
Author
There was a problem hiding this comment.
I don't know.
Is it not code brought over from the assessment results "try again" button, where the assessment page refreshes to rerender the assessment from the start?
… with super class methods not always being called for `onInit` and `onRestore`. Updated to latest Lifecycle logic to distinguish between first attempt and reset attempts.
…de the journal name change. Fixed issue where 6faa60e introduced old duplicates of some methods in `Attempts`.
…stored attempts (fixes #23).
…in c2b06d5404a1d9e52ac3d4b169e14436bfc965b3. Switched to using `Passmark` from scoring plugin to save duplication (only requiresPassedSubsets is different and set to false as default).
…f6ec9228e8210585f9812).
danielghost
moved this from Needs Reviewing
to Assigned
in adapt_framework: The TODO Board
… to an execution order issue. It needed to update before `onCompleted`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21
requires adaptlearning/adapt-contrib-scoring#30
Breaking
Stateto help save and restore to offline storageLifecycleSetintegrated lifecycle functionsrawModelsandmodelstomodelsandavailableModelswhere relevant