Skip to content

Chore: Update stale YouTube event-broadcast comment (closes #26) #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swashbuck wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Chore: Update stale YouTube event-broadcast comment (closes #26) #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f95e0d9
Chore: Update stale YouTube event-broadcast comment (closes #26)
swashbuck Jun 4, 2026
2715913
Chore: Update README metadata footer
swashbuck Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,9 @@ The attributes listed below are used in *components.json* to configure **Adapt Y
No known limitations

----------------------------
**Framework versions:** 5.19.1<br>
**Author / maintainer:** Adapt Core Team with [contributors](https://github.com/adaptlearning/adapt-youtube/graphs/contributors)

<a href="https://community.adaptlearning.org/" target="_blank"><img src="https://github.com/adaptlearning/documentation/blob/master/04_wiki_assets/plug-ins/images/adapt-logo-mrgn-lft.jpg" alt="adapt learning logo" align="right"></a><br>
**Author / maintainer:** Adapt Core Team with [contributors](https://github.com/adaptlearning/adapt-youtube/graphs/contributors)<br>
**Accessibility support:** WAI AA<br>
**RTL support:** Yes<br>
**Cross-platform coverage:** Chrome, Chrome for Android, Firefox (ESR + latest version), Edge, Safari for macOS/iOS/iPadOS, Opera<br>
14 changes: 8 additions & 6 deletions js/YouTubeView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,14 @@ export default class YouTubeView extends ComponentView {
}

/**
* this seems to have issues in Chrome if the user is logged into YouTube (possibly any Google account) - the API just doesn't broadcast the events
* but instead throws the error:
* Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://www.youtube.com') does not match the recipient window's origin ('http://www.youtube.com').
* This is documented here:
* https://code.google.com/p/gdata-issues/issues/detail?id=5788
* but I haven't managed to get any of the workarounds to work... :-(
* Historically, Chrome with a signed-in Google account could silently drop
* player state events, throwing:
* Failed to execute 'postMessage' on 'DOMWindow': The target origin provided
* ('https://www.youtube.com') does not match the recipient window's origin
* ('http://www.youtube.com').
* Upstream: https://issuetracker.google.com/issues/35174286
* (closed Won't Fix / Not Reproducible, 2020). No longer reproducible now that
* the page and the YouTube embed are both served over https. Kept for context.
*/
onPlayerStateChange(e) {
switch (e.data) {
Expand Down