New: Add --capturedir and --rootdir to grunt migration tasks (fixes #3667)#3668
Merged
Conversation
|
🎉 This PR is included in version 5.46.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Member
|
Have just come across an AAT issue related to this PR - specifically these lines. The AAT passes absolute paths, so we were getting something like Switching from If we should be passing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3667
New
Test
Capture cwd plugins and data
--outputdirchanges away fromsrc/courseto a defined folder relative to the cwd, usuallybuild/or an AAT temp folder for the course json and assets--capturedirdefaults to./migrations/and specifies where to write the capture output for migrationTo capture the course-data
./src/courseand./src/plugins at./migrations/:$ grunt migration:captureTo capture the course-data
./build/courseand./src/plugins at./migrations/:$ grunt migration:capture --outputdir=build/To capture the course-data
./build/courseand./src/plugins at./captured/:$ grunt migration:capture --outputdir=build/ --capturedir=./captured/Capture plugins and data from another directory
--rootdirdefaults to cwd and is where the from-framework plugins andsrc/courseare located--outputdirchanges away fromsrc/courseto a defined folder relative to the--rootdir, usuallybuild/or an AAT temp folder for the course json and assets--capturedirdefaults to./migrations/and specifies where to write the capture output for migrationTo capture the course-data
../old_course/src/courseand../old_courseplugins at./migrations/:$ grunt migration:capture --rootdir=../old_course/To capture the course-data
../old_course/src/courseand../old_courseplugins at./captured/:$ grunt migration:capture --rootdir=../old_course/ --capturedir=captured/To capture the course-data
../old_course/build/courseand../old_courseplugins at./captured/:$ grunt migration:capture --rootdir=../old_course/ --outputdir=build/ --capturedir=captured/Migrate
The to-framework plugins are always the plugins specified in the cwd.
--outputdirchanges away fromsrc/courseto a defined folder relative to the cwd, usuallybuild/or an AAT temp folder for the course json and assets--capturedirdefaults to./migrations/and specifies where to read the capture data for migrationTo migrate the captured data
./captured/to./src/courseusing the to-framework plugins from cwd:$ grunt migration:migrate --capturedir=captured/To migrate the captured data
./captured/to./build/courseusing the to-framework plugins from cwd:$ grunt migration:migrate --capturedir=captured/ --outputdir=build/