You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In getMetadata, the cache lookup uses cachedMetadata[path] but the function parameter is named url. This will cause a reference error and prevent caching from working.
The path variable is undefined in this context and should be replaced with the function parameter url to correctly key the cache. This will fix the cache lookup logic and prevent runtime errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Import
FullMetadatatypeInitialize URL-to-promise metadata cache
Implement caching in
getMetadataReturn cached metadata on repeated calls
Changes walkthrough 📝
storage.ts
Introduce metadata caching in storagestores/storage.ts
FullMetadatafrom storage APIcachedMetadatamapping URLs to promisesgetMetadatato store metadata promise